[webkit-reviews] review granted: [Bug 34297] [Win] Fix a bug of round() with huge integral numbers : [Attachment 47665] Proposed patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted TAMURA, Kent <tkent at chromium.org>'s
request for review:
Bug 34297: [Win] Fix a bug of round() with huge integral numbers
https://bugs.webkit.org/show_bug.cgi?id=34297

Attachment 47665: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=47665&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +    if (!_finite(num))
> +	   return num;

Seems bad for performance to do this. Can't we just leave this out? It seems
that infinity or NAN would be unchanged by the code below.

> +    double tmp = ceil(num);

I think we can come up with a better name than "tmp" for this. I suggest
"ceiling" or "integer"?