[webkit-reviews] review granted: [Bug 34343] Client-based Geolocation starts updating before getting consent from the user : [Attachment 47732] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Steve Falkenburg
<sfalken at apple.com>'s request for review:
Bug 34343: Client-based Geolocation starts updating before getting consent from
the user
https://bugs.webkit.org/show_bug.cgi?id=34343

Attachment 47732: Patch
https://bugs.webkit.org/attachment.cgi?id=47732&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +	       ASSERT(m_frame);
> +	       Page* page = m_frame->page();
> +	       ASSERT(page);
> +	       page->geolocationController()->addObserver(this);

What guarantees they are non-zero? You should figure out what the right
behavior would be in those cases and handle instead of asserting.

Otherwise, r=me