[webkit-reviews] review denied: [Bug 34306] Convert editing/selection/5136696.html to dumpAsText : [Attachment 47673] Convert the test

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 29 10:13:52 PST 2010


David Levin <levin at chromium.org> has denied Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 34306: Convert editing/selection/5136696.html to dumpAsText
https://bugs.webkit.org/show_bug.cgi?id=34306

Attachment 47673: Convert the test
https://bugs.webkit.org/attachment.cgi?id=47673&action=review

------- Additional Comments from David Levin <levin at chromium.org>
I'm not too familiar with this test, but I tried to ensure that the final
result would test the same thing that the test was verifying before.

To me it looks like converting this test to dumpAsText in this manner destroys
what it was trying to do. It looks like with the patch, this test no longer
verifies that text is selected anymore nor does it verify what has focus.


More information about the webkit-reviews mailing list