[webkit-reviews] review granted: [Bug 34309] MSAA: Crash when posting a notification for a detached object : [Attachment 47687] patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Jon Honeycutt
<jhoneycutt at apple.com>'s request for review:
Bug 34309: MSAA: Crash when posting a notification for a detached object
https://bugs.webkit.org/show_bug.cgi?id=34309

Attachment 47687: patch
https://bugs.webkit.org/attachment.cgi?id=47687&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +	   * accessibility/AccessibilityRenderObject.cpp:
> +	   (AccessibilityRenderObject::document):
> +	   Null check m_renderer.

I presume this is the bug fix.

> +	   * accessibility/win/AXObjectCacheWin.cpp:
> +	   (WebCore::AXObjectCache::postPlatformNotification):
> +	   Map AXValueChanged to EVENT_OBJECT_VALUECHANGED.

What does this have to do with the bug report? Is it just something else you
noticed when making the test case?

I must admit this is one of the largest patches I have ever seen to fix a
null-dereference!

r=me