[webkit-reviews] review granted: [Bug 34327] [Gtk] Vimeo HTML5 player doesn't work : [Attachment 47713] Send Referer when requesting media over HTTP

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 29 06:42:34 PST 2010


Gustavo Noronha (kov) <gns at gnome.org> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 34327: [Gtk] Vimeo HTML5 player doesn't work
https://bugs.webkit.org/show_bug.cgi?id=34327

Attachment 47713: Send Referer when requesting media over HTTP
https://bugs.webkit.org/attachment.cgi?id=47713&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
 166		 gchar* referer =
g_strdup(document->documentURI().utf8().data());
 167		 g_printerr("Referer: %s\n", referer);

As discussed on IRC, drop the referer variable, and the g_strdup, and pass
document->documentURI().utf8().data() directly to gst_structure_new. Also
remove the g_printerr =).


More information about the webkit-reviews mailing list