[webkit-reviews] review canceled: [Bug 34269] Web Inspector: Use platform-specific fonts for SourceFrame contents : [Attachment 47706] [PATCH] Proposed solution

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has canceled Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 34269: Web Inspector: Use platform-specific fonts for SourceFrame contents
https://bugs.webkit.org/show_bug.cgi?id=34269

Attachment 47706: [PATCH] Proposed solution
https://bugs.webkit.org/attachment.cgi?id=47706&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
>      this._textModel = textModel;
>      this._textModel.changeListener = this._textChanged.bind(this);
> +    if (!WebInspector.TextEditor.PlatformFonts) {
> +	   WebInspector.TextEditor.PlatformFonts = {};
> +	   WebInspector.TextEditor.PlatformFonts[WebInspector.OS.Windows] =
{size: 12, face: "Lucida Console"};
> +	  
WebInspector.TextEditor.PlatformFonts[WebInspector.OS.WindowsVistaOrLater] =
{size: 12, face: "Courier"};
> +	  
WebInspector.TextEditor.PlatformFonts[WebInspector.OS.MacSnowLeopard] = {size:
11, face: "Menlo"};
> +	   WebInspector.TextEditor.PlatformFonts[WebInspector.OS.MacLeopard] =
{size: 10, face: "Monaco"};
> +	   WebInspector.TextEditor.PlatformFonts[WebInspector.OS.MacTiger] =
{size: 10, face: "Monaco"};
> +    }
> +

should this be defined in init font?


> +    this._isMac = platform === WebInspector.OS.MacTiger || platform ===
WebInspector.OS.MacLeopard || platform === WebInspector.OS.MacSnowLeopard;
>  

indexOf("mac") === 0?


> +	       const fontMetrics =
WebInspector.TextEditor.PlatformFonts[platform] || {size: 10, face:
"monospace"};

fontInfo?