[webkit-reviews] review granted: [Bug 34298] [Chromium] StorageNamespaceProxy::copy() should be a no-op : [Attachment 47664] Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Jeremy Orlow
<jorlow at chromium.org>'s request for review:
Bug 34298: [Chromium] StorageNamespaceProxy::copy() should be a no-op
https://bugs.webkit.org/show_bug.cgi?id=34298

Attachment 47664: Patch
https://bugs.webkit.org/attachment.cgi?id=47664&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
> +    // The WebViewClient knows what its session storage namespace id is but
we
> +    // do not.  Returning 0 here causes it to be fetched (via
theWebViewClient)

nit: "theWebViewClient" -> "the WebViewClient"


> +    // on its next use.  Note that it is WebViewClient::createView's
> +    // responsibility to clone the session storage namespace id and that the

> +    // only time copy() is called is directly after the createView
call...which
> +    // is why all of this is safe.

nit: It seems like some of this should be documented on
WebViewClient::createView.

R=me

Feel free to fixup comments and commit.