[webkit-reviews] review granted: [Bug 34302] RenderVideo should prefer provided width/height properties to hard coded defaults when natural size is unavailable : [Attachment 47669] Initial Patch.

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Nick Young
<nicholas.young at nokia.com>'s request for review:
Bug 34302: RenderVideo should prefer provided width/height properties to hard
coded defaults when natural size is unavailable
https://bugs.webkit.org/show_bug.cgi?id=34302

Attachment 47669: Initial Patch.
https://bugs.webkit.org/attachment.cgi?id=47669&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
>	   // size since they also have audio thrown at them. By setting the
intrinsic
>	   // size to 300x1 the video will resize itself in these cases, and
audio will
>	   // have the correct height (it needs to be > 0 for controls to
render properly).
> -	   if (video->ownerDocument() &&
video->ownerDocument()->isMediaDocument())
> +	   if (video->hasAttribute(widthAttr) &&
video->hasAttribute(heightAttr))
> +	       setIntrinsicSize(IntSize(video->width(), video->height()));
> +	   else if (video->ownerDocument() &&
video->ownerDocument()->isMediaDocument())

This comment doesn't make sense now, it is about the second test. Please add a
comment about the logic in the first test ("Prefer provided video element
width/height properties...") and move this comment down to be with the second
test.

r=me with this change