[webkit-reviews] review granted: [Bug 33405] [OpenVG] Implement a basic GraphicsContext on top of a new PainterOpenVG class : [Attachment 47659] Implement a basic GraphicsContext on top of a new PainterOpenVG class

[bugzilla-daemon at webkit.org]

Nikolas Zimmermann <zimmermann at kde.org> has granted Jakob Petsovits
<jpetsovits at rim.com>'s request for review:
Bug 33405: [OpenVG] Implement a basic GraphicsContext on top of a new
PainterOpenVG class
https://bugs.webkit.org/show_bug.cgi?id=33405

Attachment 47659: Implement a basic GraphicsContext on top of a new
PainterOpenVG class
https://bugs.webkit.org/attachment.cgi?id=47659&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
r=me, nice patch! Please fix some last style issues before landing:
 330	 inline bool strokeDisabled() const
 331	 {
 332	     return (compositeOperation == CompositeSourceOver
 333		 && (strokeStyle == NoStroke || !strokeColor.alpha()));
 334	 }
 335 
 336	 inline bool fillDisabled() const
 337	 {
 338	     return (compositeOperation == CompositeSourceOver &&
!fillColor.alpha());
 339	 }
 340 };
Outer parenthesis shoul dbe removed.

 88	void drawRect(const FloatRect&, VGbitfield paintModes = (VG_STROKE_PATH
| VG_FILL_PATH));

Ditto.