[webkit-reviews] review denied: [Bug 33405] [OpenVG] Implement a basic GraphicsContext on top of a new PainterOpenVG class : [Attachment 47172] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 28 15:42:18 PST 2010


Nikolas Zimmermann <zimmermann at kde.org> has denied Jakob Petsovits
<jpetsovits at rim.com>'s request for review:
Bug 33405: [OpenVG] Implement a basic GraphicsContext on top of a new
PainterOpenVG class
https://bugs.webkit.org/show_bug.cgi?id=33405

Attachment 47172: Patch
https://bugs.webkit.org/attachment.cgi?id=47172&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
r- as discussed with Jakob. We've went through the patch line-by-line, and
there are some issues in GraphicsContext regarding not checking for m_data != 0
and/or surface->makeCurrent() calls missing. A new patch will be prepared :-)


More information about the webkit-reviews mailing list