[webkit-reviews] review granted: [Bug 34266] [v8] Crash - WebCore::ScriptController::mainWorldScriptState() : [Attachment 47641] patch addressing reviewers comments

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Yury Semikhatsky
<yurys at chromium.org>'s request for review:
Bug 34266: [v8] Crash - WebCore::ScriptController::mainWorldScriptState()
https://bugs.webkit.org/show_bug.cgi?id=34266

Attachment 47641: patch addressing reviewers comments
https://bugs.webkit.org/attachment.cgi?id=47641&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
> > 2) Can we make the ScriptState destructor private to ensure that it's only
> > deleted via the weak callback?
> >
> Good point. I've added FIXME comment since there is one call to the
destructor
> on the Chromium side and we need to get rid of it first.

Is this call going to cause a double free?  Please ensure that it's ok before
landing.

Thanks!