[webkit-reviews] review canceled: [Bug 18662] Extend keyboard navigation to allow directional navigation : [Attachment 47592] Add directional navigation to WebCore (v10++)

[bugzilla-daemon at webkit.org]

Antonio Gomes (tonikitoo) <tonikitoo at webkit.org> has canceled Antonio Gomes
(tonikitoo) <tonikitoo at webkit.org>'s request for review:
Bug 18662: Extend keyboard navigation to allow directional navigation
https://bugs.webkit.org/show_bug.cgi?id=18662

Attachment 47592: Add directional navigation to WebCore (v10++)
https://bugs.webkit.org/attachment.cgi?id=47592&action=review

------- Additional Comments from Antonio Gomes (tonikitoo)
<tonikitoo at webkit.org>
Patch v11:

Summary:
1) Improves the algorithm inicially proposed by Marco Barisione:
* Now it is based on a super-precedence logic, whereas rects whose middle
  falls between the top or bottom of the current rect are preferible to
  move focus to. It falls back to the common eucledian distance.
2) Adds 8 LayoutLayout for the following edge cases:
* table traversal.
* tiny table traversal (which validates the rect inflate value used).
* iframe traversal (scrollable content).
* iframe traversal (no scrollable content).
* iframe traversal (no focusable content).
* unit-overflow during distance calculation (focusable elements 100.000.000px
distant from each other).
* scroll-in-direction.
* super precedence in vertical direction.
* super precedence in horizontal direction.

TODO in followup bugs:
* Add port specific hooks to each DRTs to enable/disable Spatial Navigation
(see bug 33715 for Qt).
* Form navigation and SNav interaction.
* Better support Iframes with scrollable content (working initial support
already implemented).
* Make navigation keys customizable. It currently works with arrows keys only
  (up, down, right and left).
* Make it support modifiers (Alt, Ctrl and Shift).


Diff from patch 47592 "v10++":
* Fixes issues related to the scrollOffset usage inside iframes.