[webkit-reviews] review denied: [Bug 34266] [v8] Crash - WebCore::ScriptController::mainWorldScriptState() : [Attachment 47621] patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Yury Semikhatsky
<yurys at chromium.org>'s request for review:
Bug 34266: [v8] Crash - WebCore::ScriptController::mainWorldScriptState()
https://bugs.webkit.org/show_bug.cgi?id=34266

Attachment 47621: patch
https://bugs.webkit.org/attachment.cgi?id=47621&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
This looks great.  A few comments:

1) Please use V8HiddenPropertyNames for the ScriptState hidden property name.

2) Can we make the ScriptState destructor private to ensure that it's only
deleted via the weak callback?

3) Have you tested performance?  Hidden properties are relatively slow, so we
need to make sure this isn't used in any performance critical places.

Also, please fix the style nit.