[webkit-reviews] review granted: [Bug 34249] check-webkit-style: Remove filename parameter from all functions where no longer used : [Attachment 47606] Proposed patch

[bugzilla-daemon at webkit.org]

Shinichiro Hamaji <hamaji at chromium.org> has granted Chris Jerdonek
<cjerdonek at webkit.org>'s request for review:
Bug 34249: check-webkit-style: Remove filename parameter from all functions
where no longer used
https://bugs.webkit.org/show_bug.cgi?id=34249

Attachment 47606: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=47606&action=review

------- Additional Comments from Shinichiro Hamaji <hamaji at chromium.org>
Looks good except the following nitpicks.

> -    if filename.endswith('.cpp'):
> +    if file_extension == ('cpp'):

Unnecessary parentheses around 'cpp' ?

> -    elif filename.endswith('.c'):
> +    elif file_extension == ('c'):

Ditto.

> -    error_message = include_state.check_next_include_order(header_type,
filename.endswith('.h'))
> +    error_message = include_state.check_next_include_order(header_type,
(file_extension == "h"))

We can remove parentheses around 'file_extension == "h"', but please feel free
not to modify this if you prefer this way or you know.