[webkit-reviews] review granted: [Bug 34173] style tool: Improve treatment of conditions and rest of the line for if, else, switch and alikes : [Attachment 47555] Removing traces of incorrect redirects

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 27 23:34:14 PST 2010


Shinichiro Hamaji <hamaji at chromium.org> has granted anton muhin
<antonm at chromium.org>'s request for review:
Bug 34173: style tool: Improve treatment of conditions and rest of the line for
if, else, switch and alikes
https://bugs.webkit.org/show_bug.cgi?id=34173

Attachment 47555: Removing traces of incorrect redirects
https://bugs.webkit.org/attachment.cgi?id=47555&action=review

------- Additional Comments from Shinichiro Hamaji <hamaji at chromium.org>
> but I still decided to allow lines
> terminating with \ as multiline macros are too painful to write.  And \ are
> kind of legitime C code.
> 
> Spotted a nice case of macro to inline function conversion which kept \ at
the
> end :)

Ah, very nice catch. Thanks for doing this check.


More information about the webkit-reviews mailing list