[webkit-reviews] review requested: [Bug 33680] [V8] Generate header declaration for custom constructor callbacks : [Attachment 47580] Added handling of 'CanBeConstructed' and 'OmitConstructor' in addition to 'CustomConstructor'

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 27 17:20:06 PST 2010


Kavita Kanetkar <kkanetkar at chromium.org> has asked  for review:
Bug 33680: [V8] Generate header declaration for custom constructor callbacks
https://bugs.webkit.org/show_bug.cgi?id=33680

Attachment 47580: Added handling of 'CanBeConstructed' and 'OmitConstructor' in
addition to 'CustomConstructor'
https://bugs.webkit.org/attachment.cgi?id=47580&action=review

------- Additional Comments from Kavita Kanetkar <kkanetkar at chromium.org>
Changed the following from the previous patch:
- Deleted implementation .cpp files for corresponding 'CanBeConstructed'
extended attributes. These are now generated via codegeneratorv8.pm
- Treating 'OmitConstructor' and 'CustomConstructor' to be the same in
codegeneratorjs.pm
- Cleaned idls that had 'CustomConstructor' and 'OmitConstructor' together, and
same with CustomConstructor and CanBeConstructed.


More information about the webkit-reviews mailing list