[webkit-reviews] review denied: [Bug 34019] Custom-written JavaScript parser : [Attachment 47525] Next attempt

[bugzilla-daemon at webkit.org]

Oliver Hunt <oliver at apple.com> has denied Zoltan Herczeg
<zherczeg at webkit.org>'s request for review:
Bug 34019: Custom-written JavaScript parser
https://bugs.webkit.org/show_bug.cgi?id=34019

Attachment 47525: Next attempt
https://bugs.webkit.org/attachment.cgi?id=47525&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
I don't like the
case '-': ....
case '{': ...
etc

idiom. You should stick to the symbolic names like OPENBRACE -- this will also
reduce the lexer diffs, and reduce the risk of accidentally introducing a
symbolic name that overloads a character.

We also need to get the full set of tests to parse correctly.  Then we need to
fuzz this (we don't have many -- if any -- invalid script tests alas)

--Oliver