[webkit-reviews] review granted: [Bug 34209] rangeOverflow/rangeUnderflow support for type=date : [Attachment 47513] Proposed patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted TAMURA, Kent <tkent at chromium.org>'s
request for review:
Bug 34209: rangeOverflow/rangeUnderflow support for type=date
https://bugs.webkit.org/show_bug.cgi?id=34209

Attachment 47513: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=47513&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +    // Parses the src for the current type, and return the double
> +    // value for the parsing result if the parsing succeeds; Returns
> +    // defaultValue otherwise. This function can return NaN or
> +    // Infinity only if defaultValue is NaN or Infinity.
> +    double doubleValueFor(const String& src, double defaultValue) const;

If you think that the argument name is really needed, then please use the word
"source" instead of the abbreviation "src". I think you can omit the argument
name.

Might be nicer if this function name made it clearer it was a string parser.
I'm not sure "double value for <xxx>" implies parsing.