[webkit-reviews] review denied: [Bug 26083] How to access formatted Java script Console message ? : [Attachment 41397] Fix for formatted js console log message. Fixed some style issues as suggested by Adam Barth.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 27 15:38:17 PST 2010


Laszlo Gombos <laszlo.1.gombos at nokia.com> has denied Gopal Raghavan
<gop.rag at gmail.com>'s request for review:
Bug 26083: How to access formatted Java script Console message ?
https://bugs.webkit.org/show_bug.cgi?id=26083

Attachment 41397: Fix for formatted js console log message. Fixed some style
issues as suggested by Adam Barth.
https://bugs.webkit.org/attachment.cgi?id=41397&action=review

------- Additional Comments from Laszlo Gombos <laszlo.1.gombos at nokia.com>
I think this patch should have LayoutTests (fast/dom/Window/console*); this
would also help to communicate the motivation behind the patch. 

> Index: WebKit/qt/Api/qwebpage.h
> ===================================================================
> --- WebKit/qt/Api/qwebpage.h	(revision 48300)
> +++ WebKit/qt/Api/qwebpage.h	(working copy)
> @@ -338,7 +338,7 @@ protected:
>      virtual void javaScriptAlert(QWebFrame *originatingFrame, const QString&
msg);
>      virtual bool javaScriptConfirm(QWebFrame *originatingFrame, const
QString& msg);
>      virtual bool javaScriptPrompt(QWebFrame *originatingFrame, const
QString& msg, const QString& defaultValue, QString* result);
> -    virtual void javaScriptConsoleMessage(const QString& message, int
lineNumber, const QString& sourceID);
> +    virtual void javaScriptConsoleMessage(const QString& messageSource,
const QString& messageLevel, const QString& message, int lineNumber, const
QString& sourceID);
>  
>      virtual QString userAgentForUrl(const QUrl& url) const;
>  

This change breaks backward compatibility for the QtWebKit API as it changes
the type of the second argument. 

r- for lack of tests and BC break.


More information about the webkit-reviews mailing list