[webkit-reviews] review granted: [Bug 33180] [Qt] Support private browsing mode in plugins : [Attachment 47448] Updated Patch

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has granted Robert Hogan
<robert at roberthogan.net>'s request for review:
Bug 33180: [Qt] Support private browsing mode in plugins
https://bugs.webkit.org/show_bug.cgi?id=33180

Attachment 47448: Updated Patch
https://bugs.webkit.org/attachment.cgi?id=47448&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>

> +    case NPNVprivateModeBool: {
> +	   Page* page = m_parentFrame->page();
> +	   if (!page)
> +	       return NPERR_GENERIC_ERROR;
> +	   *((NPBool*)value) = !page->settings() ||
page->settings()->privateBrowsingEnabled();
> +	   return NPERR_NO_ERROR;
> +    }

r=me, but when landing you may want to change the above to return
NPERR_GENERIC_ERROR if !page->settings() and only return the real value to the
plugin if we have a settings object.