[webkit-reviews] review denied: [Bug 33096] [Qt] DRT: Support evaluateInWebInspector(), setTimerProfilingEnabled() and display(). : [Attachment 47552] Updated Patch

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has denied Robert Hogan
<robert at roberthogan.net>'s request for review:
Bug 33096: [Qt] DRT: Support evaluateInWebInspector(),
setTimerProfilingEnabled() and display().
https://bugs.webkit.org/show_bug.cgi?id=33096

Attachment 47552: Updated Patch
https://bugs.webkit.org/attachment.cgi?id=47552&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
>  void DumpRenderTree::open(const QUrl& aurl)
>  {
> +    static bool previousTestUsedWebInspector = false;
> +

A boolean is better, but my main complaint was the fact that you're using a
global object to represent state that can be stored in a simple member variable
of the DumpRenderTree class :)

Please make it a member variable.

Come to think of it: Is a boolean needed at all? Can't you simply check the
currently loaded URL, i.e.

    if (isWebInspectorTest(m_page->mainFrame()->url()))
	layoutTestController()->closeWebInspector();

>      resetToConsistentStateBeforeTesting();
>  
>      QUrl url = aurl;
> +    if (previousTestUsedWebInspector)
> +	   layoutTestController()->closeWebInspector();
> +
> +    if (isWebInspectorTest(url)) {
> +	   layoutTestController()->showWebInspector();
> +	   previousTestUsedWebInspector = true;
> +    }
> +
>      m_expectedHash = QString();
>      if (m_dumpPixels) {