[webkit-reviews] review denied: [Bug 34195] CSS 'page-break-inside' property should be 'non-inherited' property. : [Attachment 47491] page-break-inside-non-inherited-style-fixed

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 27 12:58:11 PST 2010


Darin Adler <darin at apple.com> has denied Hayato Ito <hayato at chromium.org>'s
request for review:
Bug 34195: CSS 'page-break-inside' property should be 'non-inherited' property.
https://bugs.webkit.org/show_bug.cgi?id=34195

Attachment 47491: page-break-inside-non-inherited-style-fixed
https://bugs.webkit.org/attachment.cgi?id=47491&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +	       return (_effectiveDisplay == other._effectiveDisplay)

If you're reformatting this, I suggest removing the unneeded parentheses as
well.

This change needs a test case. review- because of the lack of a test case.


More information about the webkit-reviews mailing list