[webkit-reviews] review granted: [Bug 33875] [Qt] QWebPage::userAgentForUrl is terrible API : [Attachment 46962] Add a QWebPage::setUserAgent which will allow us to not call userAgentForUrl and avoid the KURL -> QUrl conversion
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jan 27 08:32:08 PST 2010
Simon Hausmann <hausmann at webkit.org> has granted Holger Freyther
<zecke at selfish.org>'s request for review:
Bug 33875: [Qt] QWebPage::userAgentForUrl is terrible API
https://bugs.webkit.org/show_bug.cgi?id=33875
Attachment 46962: Add a QWebPage::setUserAgent which will allow us to not call
userAgentForUrl and avoid the KURL -> QUrl conversion
https://bugs.webkit.org/attachment.cgi?id=46962&action=review
------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
Apart from the default argument this patch looks good to me. A nice speed-up
and API convenience :)
More information about the webkit-reviews
mailing list