[webkit-reviews] review denied: [Bug 33327] [GTK] Expose the IM context via the API : [Attachment 47504] Updated patch (fixes style issues and passes tests)

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has denied Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 33327: [GTK] Expose the IM context via the API
https://bugs.webkit.org/show_bug.cgi?id=33327

Attachment 47504: Updated patch (fixes style issues and passes tests)
https://bugs.webkit.org/attachment.cgi?id=47504&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>

> +	   Expose the GtkIMMultiContext as a property of WebKitWebView. This
will
> +	   allow embedders to generate the input method context menu entires
and

s/entires/entries/

> +    * This is the input method context used for all text entry widgets
inside
> +    * the #WebKitWebView. It can be used to generate context menu items for
> +    * controlling the active input method. g_object_unref does not need to
be
> +    * called after retrieving this property.

I don't think this is true. g_object_get will increase the ref count of the
object it is getting, so you need to unref it, right? You could say that the
WebView is the owner of the object, though.