[webkit-reviews] review denied: [Bug 34160] [Qt] Add support for Maemo zoom keys in QtLauncher : [Attachment 47399] Patch

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has denied Andreas Kling
<andreas.kling at nokia.com>'s request for review:
Bug 34160: [Qt] Add support for Maemo zoom keys in QtLauncher
https://bugs.webkit.org/show_bug.cgi?id=34160

Attachment 47399: Patch
https://bugs.webkit.org/attachment.cgi?id=47399&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>

> +
> +#ifdef Q_WS_MAEMO_5
> +    ~MainWindow()
> +    {
> +	   grabZoomKeys(false);
>      }
> +#endif

I suggest to move the #ifdefs into the function body. (as well as in
keyPressEvent)

>  #if QT_VERSION >= QT_VERSION_CHECK(4, 6, 0)
>      void sendTouchEvent()
> @@ -193,6 +209,9 @@ public:
>  
>      bool eventFilter(QObject* obj, QEvent* event)
>      {
> +	   // MAEMO: The X11 headers macro "KeyPress" which breaks
"QEvent::KeyPress"...
> +	   const int QEvent_KeyPress = 6;

A better way to fix this is to #undef KeyPress after including the X11 headers.



The rest looks good to me :)