[webkit-reviews] review denied: [Bug 33747] Handle broken images more correctly in the open-source image decoders : [Attachment 46716] patch v1

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has denied Peter Kasting
<pkasting at google.com>'s request for review:
Bug 33747: Handle broken images more correctly in the open-source image
decoders
https://bugs.webkit.org/show_bug.cgi?id=33747

Attachment 46716: patch v1
https://bugs.webkit.org/attachment.cgi?id=46716&action=review

------- Additional Comments from David Levin <levin at chromium.org>
> Index: WebCore/ChangeLog
> ===================================================================
> --- WebCore/ChangeLog (revision 53348)
> +++ WebCore/ChangeLog (working copy)
> @@ -1,3 +1,19 @@
> +2010-01-15  Peter Kasting  <pkasting at google.com>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   Handle broken images more correctly in the open-source image
decoders.
> +	   https://bugs.webkit.org/show_bug.cgi?id=33747
> +

There should be either be tests in this patch or a note about why there are no
tests.

> +	   * platform/graphics/ImageSource.cpp:
> +	   (WebCore::ImageSource::createFrameAtIndex):

It is nice to add per function level comments when possible. For example, for
this function you might say:

Removed a condition added to avoid calling size because it is now always ok to
call size here.


> +	   * platform/image-decoders/ImageDecoder.h:
> +	   (WebCore::ImageDecoder::size):
> +	   * platform/image-decoders/qt/RGBA32BufferQt.cpp:
> +	   (WebCore::RGBA32Buffer::setSize):
> +	   * platform/image-decoders/skia/ImageDecoderSkia.cpp:
> +	   (WebCore::RGBA32Buffer::setSize):
> +