[webkit-reviews] review granted: [Bug 33840] Provide a way to get page number with layoutTestController : [Attachment 47157] Patch v2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 26 15:06:02 PST 2010


Eric Seidel <eric at webkit.org> has granted Shinichiro Hamaji
<hamaji at chromium.org>'s request for review:
Bug 33840: Provide a way to get page number with layoutTestController
https://bugs.webkit.org/show_bug.cgi?id=33840

Attachment 47157: Patch v2
https://bugs.webkit.org/attachment.cgi?id=47157&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
pageNumberForElement should take in a width/height, or maybe a Vector of
IntSize's (since that's what other parts of this code use).

Otherwise I think this is a fantastic change!


More information about the webkit-reviews mailing list