[webkit-reviews] review denied: [Bug 33568] [BREWMP] Port vprintf_stderr_common : [Attachment 47256] Port vprintf_stderr_common
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jan 26 14:44:02 PST 2010
Eric Seidel <eric at webkit.org> has denied Kwang Yul Seo
<kwangyul.seo at gmail.com>'s request for review:
Bug 33568: [BREWMP] Port vprintf_stderr_common
https://bugs.webkit.org/show_bug.cgi?id=33568
Attachment 47256: Port vprintf_stderr_common
https://bugs.webkit.org/attachment.cgi?id=47256&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
OK, but lets fix Assertions.h for the COMPILE_ASSERT problem.
If you're mallocing locally, you should use an OwnPtr. Or maybe a Vector<char>
here.
More information about the webkit-reviews
mailing list