[webkit-reviews] review denied: [Bug 33882] The Chromium API should expose EventListeners : [Attachment 47438] Chromium Event Listener API
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jan 26 14:16:15 PST 2010
Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Jay Campan
<jcampan at google.com>'s request for review:
Bug 33882: The Chromium API should expose EventListeners
https://bugs.webkit.org/show_bug.cgi?id=33882
Attachment 47438: Chromium Event Listener API
https://bugs.webkit.org/attachment.cgi?id=47438&action=review
------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
> Index: WebKit/chromium/public/WebEvent.h
...
> + template<typename T> T* unwrap()
> + {
> + return static_cast<T*>(m_private);
> + }
> +
> + template<typename T> const T* constUnwrap() const
> + {
> + return static_cast<const T*>(m_private);
> + }
^^^ these unwrap methods are not used.
everything else LGTM.
also, it looks like the it doesn't compile properly under chromium linux.
More information about the webkit-reviews
mailing list