[webkit-reviews] review denied: [Bug 34167] [Qt] DRT WebHistory support : [Attachment 47427] Proposed patch to pass history tests

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has denied Kenneth Rohde
Christiansen <kenneth at webkit.org>'s request for review:
Bug 34167: [Qt] DRT WebHistory support
https://bugs.webkit.org/show_bug.cgi?id=34167

Attachment 47427: Proposed patch to pass history tests
https://bugs.webkit.org/attachment.cgi?id=47427&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>

> +    // Subtract one here as out QWebHistory::count() includes the actual
page,
> +    // which is not considered in the DRT tests.

our, not out

> +    return m_webHistory->count() - 1;
> +}
> +
>  void LayoutTestController::keepWebHistory()
>  {
> -    // FIXME: implement
> +    m_webHistory = m_drt->webPage()->history();
>  }