[webkit-reviews] review granted: [Bug 32696] HTMLInputElement::valueAsNumber support : [Attachment 47393] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 26 09:01:49 PST 2010


Darin Adler <darin at apple.com> has granted TAMURA, Kent <tkent at chromium.org>'s
request for review:
Bug 32696: HTMLInputElement::valueAsNumber support
https://bugs.webkit.org/show_bug.cgi?id=32696

Attachment 47393: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=47393&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +    const double nan = std::numeric_limits<double>::quiet_NaN();

Normally we omit the "std" for things like this, and have "using namespace std"
at the top of the file.

r=me


More information about the webkit-reviews mailing list