[webkit-reviews] review requested: [Bug 30914] [Qt] Javascript Prompt API default return values check failure on QtLauncher : [Attachment 47385] Possible fix with updated manual test

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 25 21:04:44 PST 2010


Holger Freyther <zecke at selfish.org> has asked  for review:
Bug 30914: [Qt] Javascript Prompt API default return values check failure on
QtLauncher
https://bugs.webkit.org/show_bug.cgi?id=30914

Attachment 47385: Possible fix with updated manual test
https://bugs.webkit.org/attachment.cgi?id=47385&action=review

------- Additional Comments from Holger Freyther <zecke at selfish.org>
Yael, you are totally correct. It probably should be 'x' and not result. I have
updated the test case and included your fix. Could you please give it a try? I
did not have time to compile it. I will do it in a second.


More information about the webkit-reviews mailing list