[webkit-reviews] review requested: [Bug 34049] ScrollbarTheme[Chromium]Mac.mm wrongly set scrollbar view size to page step size : [Attachment 47380] Layout test rebaselines

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 25 18:02:13 PST 2010


Peter Kasting <pkasting at google.com> has asked  for review:
Bug 34049: ScrollbarTheme[Chromium]Mac.mm wrongly set scrollbar view size to
page step size
https://bugs.webkit.org/show_bug.cgi?id=34049

Attachment 47380: Layout test rebaselines
https://bugs.webkit.org/attachment.cgi?id=47380&action=review

------- Additional Comments from Peter Kasting <pkasting at google.com>
Here are the layout test rebaselines to go with the patch.

There are also a few other tests I should mention:
* The following tests have a pixel diff showing scroll thumb length changes,
but are actually caused by some other pre-existing change, not my patch:
  * fast/block/margin-collapse/103.html
  * fast/inline/long-wrapped-line.html
  * fast/multicol/float-multicol.html
* The following tests are affected by my change, but also already have other
pixel diffs, so I won't rebaseline them to avoid papering over other
regressions:
  * compositing/layers-inside-overflow-scroll.html
  * compositing/self-painting-layers.html
  * css1/font_properties/font_family.html
  * fast/box-shadow/basic-shadows.html
  * fast/forms/textarea-scrollbar.html


More information about the webkit-reviews mailing list