[webkit-reviews] review requested: [Bug 34029] REGRESSION (r47444): PLT is 1% slower due to implementation of :valid and :invalid CSS selectors : [Attachment 47360] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jan 25 11:28:41 PST 2010
Adele Peterson <adele at apple.com> has asked for review:
Bug 34029: REGRESSION (r47444): PLT is 1% slower due to implementation of
:valid and :invalid CSS selectors
https://bugs.webkit.org/show_bug.cgi?id=34029
Attachment 47360: patch
https://bugs.webkit.org/attachment.cgi?id=47360&action=review
------- Additional Comments from Adele Peterson <adele at apple.com>
I'm still running tests, but I'm posting this for review anyway. I set a
breakpoint and verified with this patch, I won't hit the validity checks at all
while running the PLT. The tests I'm constructing now involve adding and
removing valid/invalid pseudostyles and making sure that style sharing happens
in the right circumstances.
More information about the webkit-reviews
mailing list