[webkit-reviews] review requested: [Bug 34089] Web Inspector overrides methods defined by the inspected application : [Attachment 47356] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 25 10:34:49 PST 2010


Yury Semikhatsky <yurys at chromium.org> has asked  for review:
Bug 34089: Web Inspector overrides methods defined by the inspected application
https://bugs.webkit.org/show_bug.cgi?id=34089

Attachment 47356: patch
https://bugs.webkit.org/attachment.cgi?id=47356&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
- Removed commented code.
- Removed DOM tree dump.
- I'd rather keep the new calls to InjectedScript methods with InjectedScript.
prefix because they are "static" routines, i.e. they don't depend on the state
of "this". Also if we want to use "this" in InjectedScript methods I'd convert
it into prototype based implementation to be consistent with the rest if the
code.


More information about the webkit-reviews mailing list