[webkit-reviews] review canceled: [Bug 18662] Extend keyboard navigation to allow directional navigation : [Attachment 46881] Add directional navigation to WebCore (v9)

[bugzilla-daemon at webkit.org]

Antonio Gomes (tonikitoo) <tonikitoo at webkit.org> has canceled Antonio Gomes
(tonikitoo) <tonikitoo at webkit.org>'s request for review:
Bug 18662: Extend keyboard navigation to allow directional navigation
https://bugs.webkit.org/show_bug.cgi?id=18662

Attachment 46881: Add directional navigation to WebCore (v9)
https://bugs.webkit.org/attachment.cgi?id=46881&action=review

------- Additional Comments from Antonio Gomes (tonikitoo)
<tonikitoo at webkit.org>
clearing review flag for now to incorporate further fixes and Kim's suggestion.


@Kim: Thanks for the input. Could you share the test cases you faced the
crashes ? I would hapelly add layout tests to cover these cases as well.

(In reply to comment #39)
> I make a try to use the last patch on my linux PC. However, When I went some
> websites, browser(GtkLauncher) sometimes came to crash during the keyboard
> navigation. It seems to me that the distanceIndirection() of
> FocusController.cpp needs to check if renderer of start / end node is null or

> not. To my knowledge, node can has a renderer or not.(But, I am not sure)
> 
> After modifing the source code as below, I don't meet crash further.
> 
> static long long distanceInDirection(Node* start,... 
> {
> ...
>   RenderObject* startRender = NULL;
>   startRender = start->renderer();
>   if (!startRender)
>	return -1;
> 
>   RenderObject* destRender = NULL;
>   destRender = dest->renderer();
>   if (!destRender)
>	return -1;
> ...