[webkit-reviews] review denied: [Bug 27312] [XSSAuditor] Add support for header X-XSS-Protection : [Attachment 47316] Patch with test cases

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Daniel Bates <dbates at webkit.org>'s
request for review:
Bug 27312: [XSSAuditor] Add support for header X-XSS-Protection
https://bugs.webkit.org/show_bug.cgi?id=27312

Attachment 47316: Patch with test cases
https://bugs.webkit.org/attachment.cgi?id=47316&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
This looks pretty good.  One problem though:

+ window.setTimeout(done, millisecondsToWait);

Don't want to use setTimeout to control when the test ends.  This will make the
test flaky on slow bots, like ones running valgrind.

Instead, you should count how many times the load event for the frame fires. 
It should fire a deterministic number of times.

Have you tried not waiting until done?	The load event for the main frame might
be delayed until the iframe finishes all its loading.