[webkit-reviews] review requested: [Bug 34070] Fix failure of webkit-patch unit test webkitpy.scm_unittest.SCMClassTests.test_error_handlers : [Attachment 47317] Patch with unit test

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jan 24 23:26:52 PST 2010


Daniel Bates <dbates at webkit.org> has asked  for review:
Bug 34070: Fix failure of webkit-patch unit test
webkitpy.scm_unittest.SCMClassTests.test_error_handlers
https://bugs.webkit.org/show_bug.cgi?id=34070

Attachment 47317: Patch with unit test
https://bugs.webkit.org/attachment.cgi?id=47317&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
Moves the try/catch for OSError exceptions in Executive.run_command to
Credentials.read_credentials() so that the unit test
webkitpy.scm_unittest.SCMClassTests.test_error_handlers can assert that
Executive.run_command throws an OSError exception.

Updated unit tests accordingly.


More information about the webkit-reviews mailing list