[webkit-reviews] review requested: [Bug 33887] [Qt] QGraphicsWebView shows combo box popups in the wrong position : [Attachment 47271] Patch against webkit-trubk

[bugzilla-daemon at webkit.org]

Girish Ramakrishnan <girish at forwardbias.in> has asked  for review:
Bug 33887: [Qt] QGraphicsWebView shows combo box popups in the wrong position
https://bugs.webkit.org/show_bug.cgi?id=33887

Attachment 47271: Patch against webkit-trubk
https://bugs.webkit.org/attachment.cgi?id=47271&action=review

------- Additional Comments from Girish Ramakrishnan <girish at forwardbias.in>
Note on the destructor part: In the case of QGraphicsWebView, the proxy is gets
already deleted by the time it hits the QtFallbackPopup destructor. I am unable
to create a debug build of Qt (it say out of memory!). But with qDebug() I have
verified that there is no leak and m_proxy indeed gets deleted (I made it a
QPointer and it printed out as 0 in the QtFallbackPopup destructor).

We probably need the above check for the patches against 4.6.1 too. (But from
what I saw QtFallbackPopup destructor was _never_ called in the 4.6.x WebKit).