[webkit-reviews] review requested: [Bug 32563] [V8] Generate toV8 conversion helpers, a la JSC bindings. : [Attachment 47228] First attempt at generating toV8()

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 22 14:44:31 PST 2010


Nate Chapin <japhet at chromium.org> has asked  for review:
Bug 32563: [V8] Generate toV8 conversion helpers, a la JSC bindings.
https://bugs.webkit.org/show_bug.cgi?id=32563

Attachment 47228: First attempt at generating toV8()
https://bugs.webkit.org/attachment.cgi?id=47228&action=review

------- Additional Comments from Nate Chapin <japhet at chromium.org>
This very well may not be the right answer, but it's one way to generate toV8()
converters.  This patch is primarily just generating the converters and making
the generated bindings use them.  The custom bindings still use the old
converters.

The biggest sticking point of this idea is that it moves a lot of the special
cases that currently live in V8DOMWrapper.cpp into CodeGeneratorV8.pm.	I could
see a case against that :)

Input appreciated.


More information about the webkit-reviews mailing list