[webkit-reviews] review denied: [Bug 34003] [GTK] Pass cookies to GStreamer : [Attachment 47204] 0002-Pass-cookies-to-the-GStreamer-HTTP-source.patch

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has denied Sebastian Dröge
<slomo at circular-chaos.org>'s request for review:
Bug 34003: [GTK] Pass cookies to GStreamer
https://bugs.webkit.org/show_bug.cgi?id=34003

Attachment 47204: 0002-Pass-cookies-to-the-GStreamer-HTTP-source.patch
https://bugs.webkit.org/attachment.cgi?id=47204&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
>
> @@ -49,6 +49,8 @@
>  #include <math.h>
>  #include <wtf/gtk/GOwnPtr.h>
>  
> +#include <webkit/webkitwebview.h>

This should go along with the other includes above. Between math and wtf/gtk
sounds right.

> +    if (element) {
> +	   GParamSpec *pspec = g_object_class_find_property (G_OBJECT_GET_CLASS
(element), "cookies");

You have a number of style problems in this patch - mostly spaces between
function names, and parenses, and misplaced *. Other than that, the patch looks
good. I would still prefer to be able to set the same cookie jar, though,
because I'm pretty sure we'll hit some corner case this is not going to work
for. We might as well consider, for the future, writing a custom source that
uses WebCore's machinery to download the video data, by the way.