[webkit-reviews] review granted: [Bug 34007] Implement hardware acceleration of video on Windows : [Attachment 47217] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 22 12:21:54 PST 2010


Adam Roben (aroben) <aroben at apple.com> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 34007: Implement hardware acceleration of video on Windows
https://bugs.webkit.org/show_bug.cgi?id=34007

Attachment 47217: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=47217&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
> +	   (WebCore::MediaPlayerPrivate::supportsAcceleratedRendering): New,
return true unless the 
> +	       movie is not ready to render or the movie is in a media
document.

This isn't true anymore.

> @@ -190,7 +199,7 @@ void MediaPlayerPrivate::pause()
>	   return;
>      m_startedPlaying = false;
>  #if DRAW_FRAME_RATE
> -    m_timeStoppedPlaying = GetTickCount();
> +    m_timeStoppedPlaying = WTF::currentTime();

You shouldn't need the "WTF::" here.

r=me


More information about the webkit-reviews mailing list