[webkit-reviews] review granted: [Bug 33985] The Chromium WebKit API needs to expose storage event related data : [Attachment 47213] Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Jeremy Orlow
<jorlow at chromium.org>'s request for review:
Bug 33985: The Chromium WebKit API needs to expose storage event related data
https://bugs.webkit.org/show_bug.cgi?id=33985

Attachment 47213: Patch
https://bugs.webkit.org/attachment.cgi?id=47213&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
> Index: WebKit/chromium/public/WebStorageArea.h
...
> +    virtual void setItem(const WebString& key, const WebString& newValue,
const WebURL& url, bool& quotaException) // Deprecated.
> +    {
> +	   WebString oldValue;
> +	   setItem(key, newValue, url, quotaException, trash);

s/trash/oldValue/ ?


> +    virtual void clear(const WebURL& url) // Deprecated.
> +    {
> +	   WebString somethingCleared;
> +	   clear(url, somethingCleared);

WebString -> bool


Please add a FIXME note about cleaning this up once the Chromium side is
adapted.



> Index: WebKit/chromium/src/StorageAreaProxy.cpp
...
> +    if (static_cast<String>(oldValue) != value)

nit: I usually just write String(oldValue) in cases like this.	It results in
the same code.


Otherwise, r=me