[webkit-reviews] review denied: [Bug 34003] [GTK] Pass cookies to GStreamer : [Attachment 47203] 0001-Update-copy-of-the-source-whenever-playbin2-s-source.patch

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has denied Sebastian Dröge
<slomo at circular-chaos.org>'s request for review:
Bug 34003: [GTK] Pass cookies to GStreamer
https://bugs.webkit.org/show_bug.cgi?id=34003

Attachment 47203:
0001-Update-copy-of-the-source-whenever-playbin2-s-source.patch
https://bugs.webkit.org/attachment.cgi?id=47203&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
In addition to the style checker output (which seems valid for the case), I
have the following comments:

 132	 g_object_get (mp->m_playBin, "source", &element, NULL);
 133	 old_element = mp->m_source;
 134	 mp->m_source = NULL;

The old_element variable (besides having a bad name given the style) seems to
be unnecessary. You could check, and unref mp->m_source directly instead of
assigning it to another variable.

 135	 if (old_element)
 136	     gst_object_unref (old_element);
 137	 mp->m_source = element;

This looks like a crash - we are not refing the element ourselves (perhaps we
should), so unreffing it seems wrong (the same goes for the destructor).