[webkit-reviews] review requested: [Bug 33943] Use fastStrDup instead of strdup : [Attachment 47194] Use fastStrDup

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 22 05:47:53 PST 2010


Kwang Yul Seo <kwangyul.seo at gmail.com> has asked  for review:
Bug 33943: Use fastStrDup instead of strdup
https://bugs.webkit.org/show_bug.cgi?id=33943

Attachment 47194: Use fastStrDup
https://bugs.webkit.org/attachment.cgi?id=47194&action=review

------- Additional Comments from Kwang Yul Seo <kwangyul.seo at gmail.com>
fastStrDup is not so great as we can't use OwnPtr. However, it is still
valuable because we can use fastFree everywhere. In addition to it, some
compilers without strdup can benefit from fastStrDup.

I submit the patch again to make it pass build tests as 33943 is now committed
in the trunk.


More information about the webkit-reviews mailing list