[webkit-reviews] review denied: [Bug 33317] Document::minimumLayoutDelay() should return unsigned, rather than int : [Attachment 46061] Patch 1 for Bug 33317

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 21 22:48:24 PST 2010


David Levin <levin at chromium.org> has denied Steve Block
<steveblock at google.com>'s request for review:
Bug 33317: Document::minimumLayoutDelay() should return unsigned, rather than
int
https://bugs.webkit.org/show_bug.cgi?id=33317

Attachment 46061: Patch 1 for Bug 33317
https://bugs.webkit.org/attachment.cgi?id=46061&action=review

------- Additional Comments from David Levin <levin at chromium.org>
r- for two reasons:
1. This patch/changelog doesn't mention why this needs to be done only what
(and I personally hate unsigned -- been burned in the past by subtle bugs of
the nature that Darin mentioned). If there was a "why", perhaps we could
discuss alternatives :)

2. Is there a way to address Darin Adler's last comment?


More information about the webkit-reviews mailing list