[webkit-reviews] review requested: [Bug 27243] SVG JS bindings "context" pointer needs to move onto binding impls : [Attachment 47164] Updated patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 21 17:31:23 PST 2010


Nikolas Zimmermann <zimmermann at kde.org> has asked  for review:
Bug 27243: SVG JS bindings "context" pointer needs to move onto binding impls
https://bugs.webkit.org/show_bug.cgi?id=27243

Attachment 47164: Updated patch
https://bugs.webkit.org/attachment.cgi?id=47164&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
Updated this patch against ToT.

I am working on further patches in that area, that will touch all JSSVGPOD*
files (as I'm going to rewrite the ANIMATED_PROPERTY_* declaration macros for
svg/). This patch is blocking my further work, I am unable to create a
testcase, and I only did this patch to cleanup code, there is no bug about
prototype chain problems, and I don't fully understand what this patch is
supposed to fix - for me it's just cleanup :-)

Let's get this landed please, Sam was already okay with the code, just a
testcase should be created. No one came up with a testcase, so please let's
move forward even without a testcase.


More information about the webkit-reviews mailing list