[webkit-reviews] review granted: [Bug 33979] -webkit-mask-box-image draws a box while loading : [Attachment 47160] Patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org has granted Simon Fraser (smfr) <simon.fraser at apple.com>'s
request for review:
Bug 33979: -webkit-mask-box-image draws a box while loading
https://bugs.webkit.org/show_bug.cgi?id=33979

Attachment 47160: Patch
https://bugs.webkit.org/attachment.cgi?id=47160&action=review

------- Additional Comments from mitz at webkit.org
Change looks fine. Resorting to nit-picking.

> +	   <rdar://problem/7378662>
> +	   
> +	   
> +
> +	   * http/tests/misc/resources/slow-png-load.pl: Added.

Too many newlines.

> \ No newline at end of file

Too few newlines.

> +	   * rendering/RenderBox.cpp:
> +	   (WebCore::RenderBox::paintMaskImages):
> +	   * rendering/style/FillLayer.cpp:
> +	   (WebCore::FillLayer::areImagesLoaded):
> +	   * rendering/style/FillLayer.h:

Explain what you did there?

> +    bool areImagesLoaded() const;

I prefer imagesAreLoaded() or hasLoaded[All]Images().