[webkit-reviews] review denied: [Bug 33948] Object.getOwnPropertyDescriptor(window) returns descriptors for properties in the prototype chain : [Attachment 47129] Proposed patch

[bugzilla-daemon at webkit.org]

Oliver Hunt <oliver at apple.com> has denied Kent Hansen <kent.hansen at nokia.com>'s
request for review:
Bug 33948: Object.getOwnPropertyDescriptor(window) returns descriptors for
properties in the prototype chain
https://bugs.webkit.org/show_bug.cgi?id=33948

Attachment 47129: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=47129&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
r=me for the code, but your test is liekly to be unstable, possibly just do a
simple sort on the output of getOwnPropertyNames?  I think additionally your
test should test to ensure that you still see own properties.