[webkit-reviews] review denied: [Bug 33957] [v8] Implement Node map in intrusive way for better speed : [Attachment 47126] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied anton muhin <antonm at chromium.org>'s
request for review:
Bug 33957: [v8] Implement Node map in intrusive way for better speed
https://bugs.webkit.org/show_bug.cgi?id=33957

Attachment 47126: Patch
https://bugs.webkit.org/attachment.cgi?id=47126&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
+ if (!wrapper) return v8::Persistent<v8::Object>();

Should be two lines.  (This nit repeated many times.)

+ TableChunk

Why not just use Vector?

+ virtual v8::Persistent<ValueType> get(KeyType* obj)

Are these methods already virtual?  It seems like we shouldn't need that.  We
should be able to use templates to solve the dispatch problem at compile time.

r- for style, but curious about the above questions.